Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code.
Sending confirmation link on the user provided email address, by clicking this link a new page will open showing user account confirmation message. Another approach is instead of providing confirmation link, provide user with the verification code in the email, let's say number 12345 is verification code, then user will read this number.
Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.
This PR addresses issue, allow editing your own email address. Following the discussion on the issue, this implements the second of three parts, the ability to send a confirmation email to a user for verification. For a full explanation of the issue, see I left which should fully explain the changes made, as well as parts 1 and 3.In short, I added two tables to the database: one for the user's email, the other for a confirmation token associated with the email. Once the user clicks the link sent, the associated token is deleted from the token table and emailverified is set to true in the email table. It is indicated to the user if they have not verified their email on the account settings page, a message and email resend button being displayed. Sending emails requires Mailgun to be added to the crates.io Heroku account.This has applications for issue in that we should now be able to send an email to a user, if they have added their email.
I know there was a lot of discussion on that issue regarding the ability to send users an email to be added as an owner. So if this expect gets an Err, this would crash the server, which normally would make me go ? ? ? ? ? ? but looking at, the only way building an email would fail is if:. no from address was set, and we're definitely calling from with something we control. the to address is empty string, and we reject empty emails before calling senduserconfirmemail in updateuserI'm trying to figure out if it's possible that we get Some(') from github and therefore would insert an empty string into the email table and then get an empty email here? I'm going to try some testing and see what happens.This is also starting to feel a bit spooky-action-at-a-distance since the code that is ensuring the to email isn't empty is far away from here. This could be an issue for any email we send.
I wonder if, when the generic email functionality is extracted into a function, if we should pass the generic function strings for to, from, subject, and body, and then the generic function first checks to make sure to isn't an empty string and returns an Err if so, and then we can call expect and point to the line checking that should be nearby as proof that the expect won't fail? 1045: Sending an email to a user to confirm their email address r=carols10centsThis PR addresses issue, allow editing your own email address. Following the discussion on the issue, this implements the second of three parts, the ability to send a confirmation email to a user for verification.
For a full explanation of the issue, see this comment I left which should fully explain the changes made, as well as parts 1 and 3.In short, I added two tables to the database: one for the user's email, the other for a confirmation token associated with the email. Once the user clicks the link sent, the associated token is deleted from the token table and `emailverified` is set to `true` in the email table. It is indicated to the user if they have not verified their email on the account settings page, a message and email resend button being displayed. Sending emails requires Mailgun to be added to the crates.io Heroku account.This has applications for issue in that we should now be able to send an email to a user, if they have added their email.
I know there was a lot of discussion on that issue regarding the ability to send users an email to be added as an owner. 1045: Sending an email to a user to confirm their email address r=carols10centsThis PR addresses issue, allow editing your own email address. Following the discussion on the issue, this implements the second of three parts, the ability to send a confirmation email to a user for verification. For a full explanation of the issue, see this comment I left which should fully explain the changes made, as well as parts 1 and 3.In short, I added two tables to the database: one for the user's email, the other for a confirmation token associated with the email. Once the user clicks the link sent, the associated token is deleted from the token table and `emailverified` is set to `true` in the email table. It is indicated to the user if they have not verified their email on the account settings page, a message and email resend button being displayed. Sending emails requires Mailgun to be added to the crates.io Heroku account.This has applications for issue in that we should now be able to send an email to a user, if they have added their email.
I know there was a lot of discussion on that issue regarding the ability to send users an email to be added as an owner. 1045: Sending an email to a user to confirm their email address r=carols10centsThis PR addresses issue, allow editing your own email address. Following the discussion on the issue, this implements the second of three parts, the ability to send a confirmation email to a user for verification. For a full explanation of the issue, see this comment I left which should fully explain the changes made, as well as parts 1 and 3.In short, I added two tables to the database: one for the user's email, the other for a confirmation token associated with the email. Once the user clicks the link sent, the associated token is deleted from the token table and `emailverified` is set to `true` in the email table. It is indicated to the user if they have not verified their email on the account settings page, a message and email resend button being displayed.
Sending emails requires Mailgun to be added to the crates.io Heroku account.This has applications for issue in that we should now be able to send an email to a user, if they have added their email. I know there was a lot of discussion on that issue regarding the ability to send users an email to be added as an owner. Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.